ducklet/hotdog
1
0
Fork 0
Code Issues 1 Pull requests Releases Activity

feed: fix only the last configured feed being updated

Browse source 
We need to properly capture the feed-id for the callback function.
Defining the function inside the loop (even when copying feed.id into
a separate var beforehand) will not do this and will instead end up
being the same feed-id for all callback functions.
This commit is contained in:
ducklet 2020-11-16 21:09:15 +01:00
parent 124ed1cf25
commit fc4aa59f5c
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
hotdog/command/feed.py
View file

@ -30,6 +30,13 @@ def make_filter(config: Mapping[str, str]) -> Callable[[feeder.Post], bool]:
return filter return filter
def make_update_feed_cb(feed_id):
async def update_feed_cb(job: Job):
await update_feeds([feed_id], job)
return update_feed_cb
def init(bot): def init(bot):
bot.on_command("feed", handle) bot.on_command("feed", handle)
@ -63,13 +70,10 @@ def init(bot):
every_period = feedconf.get(feed.id, {}).get("update_every") every_period = feedconf.get(feed.id, {}).get("update_every")
every_s = parse_period(every_period) if every_period else one_hour every_s = parse_period(every_period) if every_period else one_hour
async def update_feed_cb(job: Job):
await update_feeds([feed.id], job)
bot.add_timer( bot.add_timer(
title=f"update feed: {feed.id}", title=f"update feed: {feed.id}",
every=every_s, every=every_s,
callback=update_feed_cb, callback=make_update_feed_cb(feed.id),
jitter=ten_percent * every_s, jitter=ten_percent * every_s,
) )