minor refactoring

This commit is contained in:
ducklet 2023-03-19 22:59:08 +01:00
parent f1bafbb4a2
commit a444909b1f

View file

@ -4,35 +4,32 @@ import pytest
from unwind import db, models, web_models
_movie_imdb_id = 1234567
def a_movie(**kwds) -> models.Movie:
global _movie_imdb_id
_movie_imdb_id += 1
args = {
"title": "test movie",
"release_year": 2013,
"media_type": "Movie",
"imdb_id": f"tt{_movie_imdb_id}",
"genres": {"genre-1"},
} | kwds
return models.Movie(**args)
@pytest.mark.asyncio
async def test_get_all(shared_conn: db.Database):
async with shared_conn.transaction(force_rollback=True):
m1 = models.Movie(
title="test movie",
release_year=2013,
media_type="Movie",
imdb_id="tt0000000",
genres={"genre-1"},
)
m1 = a_movie()
await db.add(m1)
m2 = models.Movie(
title="test movie",
release_year=2013,
media_type="Movie",
imdb_id="tt0000001",
genres={"genre-1"},
)
m2 = a_movie(release_year=m1.release_year)
await db.add(m2)
m3 = models.Movie(
title="test movie",
release_year=2014,
media_type="Movie",
imdb_id="tt0000002",
genres={"genre-1"},
)
m3 = a_movie(release_year=m1.release_year + 1)
await db.add(m3)
assert [] == list(await db.get_all(models.Movie, id="blerp"))
@ -44,22 +41,10 @@ async def test_get_all(shared_conn: db.Database):
@pytest.mark.asyncio
async def test_add_and_get(shared_conn: db.Database):
async with shared_conn.transaction(force_rollback=True):
m1 = models.Movie(
title="test movie",
release_year=2013,
media_type="Movie",
imdb_id="tt0000000",
genres={"genre-1"},
)
m1 = a_movie()
await db.add(m1)
m2 = models.Movie(
title="test movie",
release_year=2013,
media_type="Movie",
imdb_id="tt0000001",
genres={"genre-1"},
)
m2 = a_movie()
await db.add(m2)
assert m1 == await db.get(models.Movie, id=str(m1.id))
@ -69,30 +54,24 @@ async def test_add_and_get(shared_conn: db.Database):
@pytest.mark.asyncio
async def test_find_ratings(shared_conn: db.Database):
async with shared_conn.transaction(force_rollback=True):
m1 = models.Movie(
m1 = a_movie(
title="test movie",
release_year=2013,
media_type="Movie",
imdb_id="tt0000000",
genres={"genre-1"},
)
await db.add(m1)
m2 = models.Movie(
m2 = a_movie(
title="it's anöther Movie, Part 2",
release_year=2015,
media_type="Movie",
imdb_id="tt0000001",
genres={"genre-2"},
)
await db.add(m2)
m3 = models.Movie(
m3 = a_movie(
title="movie it's, Part 3",
release_year=2015,
media_type="Movie",
imdb_id="tt0000002",
genres={"genre-2"},
release_year=m2.release_year,
genres=m2.genres,
)
await db.add(m3)